Code RoomDefer in loop closes early
MediumPrep Room Coding #2384

Defer in loop closes early

Code reviewCode quality & reviewMid–Senior~18 min

Review this Go code processing many files.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min
Mark a line and say what kind of problem it is.0 findings
1func processAll(paths []string) error {
2 for _, p := range paths {
3 f, err := os.Open(p)
4 if err != nil { return err }
5 defer f.Close()
6 process(f)
7 }
8 return nil
9}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.