Code reviewMediumcr-p118

Subject SecurityLevel Mid–Senior~18 minCommon in Security interviewsIndustries Software development

Question

Review this JS code generating a session token.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjavascript

1function makeToken() {2  return Math.random().toString(36).substring(2);3}

Run or narrate your approach, then ask the coach.