Code reviewMediumcr-p125

Subject Error handlingLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this code calling a service with a timeout.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1try:2    resp = client.get(url, timeout=2)3    return resp.data4except Timeout:5    return []

Run or narrate your approach, then ask the coach.