Vibe codingHardvc-g355

Subject Ai code reviewLevel Senior–Staff~20 minCommon in Algorithms & data structures interviewsIndustries Computer games, Software development

Question

An AI agent implemented a damage-resolution system for a custom C++ ECS. Under load — many overlapping AoE hits — the game crashes intermittently and sometimes a unit takes damage twice or skips its death. Review the system and explain the structural bug.

cpp

1void DamageSystem::Update(World& world) {2    auto& healths = world.GetComponents<Health>();3    for (auto& [entity, hp] : healths) {4        hp.value -= IncomingDamage(entity);5        if (hp.value <= 0) {6            SpawnCorpse(world, entity);          // adds Corpse + Transform components7            world.RemoveComponent<Health>(entity); // mutates the map we are iterating8        }9    }10}

What a strong answer looks like

Treat the AI’s output as a draft to verify, not an answer to trust. Name the specific flaw and the input that triggers it, say how you’d catch it — tests, edge cases, reading critically — and how you’d re-prompt or decompose to get it right.

Learn the concepts

Describe your solution

Vibe coding: describe the solution in plain language (or narrate it) and the coach grades your approach. Generating runnable code from your description is coming next.

Run or narrate your approach, then ask the coach.