Code RoominnerHTML with user input
MediumPrep Room Coding #1659

innerHTML with user input

Code reviewSecurityMid–Senior~20 min

Review this TypeScript front-end component that renders a search results header.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 20 min
Mark a line and say what kind of problem it is.0 findings
1function renderHeader(container: HTMLElement) {
2 const params = new URLSearchParams(window.location.search);
3 const q = params.get('q') ?? '';
4 container.innerHTML =
5 `<h2>Results for "${q}"</h2>` +
6 `<a href="/search?q=${q}">Refine search</a>`;
7}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.