Code reviewHardcr-g028

Subject Path traversalLevel Senior–Staff~30 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java archive-extraction utility.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1void unzip(InputStream in, File destDir) throws IOException {2    try (ZipInputStream zis = new ZipInputStream(in)) {3        ZipEntry e;4        while ((e = zis.getNextEntry()) != null) {5            File out = new File(destDir, e.getName());6            out.getParentFile().mkdirs();7            try (FileOutputStream fos = new FileOutputStream(out)) {8                byte[] buf = new byte[8192];9                int n;10                while ((n = zis.read(buf)) != -1) fos.write(buf, 0, n);11            }12        }13    }14}

Run or narrate your approach, then ask the coach.