Prep Room
Sign inCreate account
Code Room
Code reviewMediumcr-g029
Subject Command injectionLevel Mid–Senior~20 minCommon in Security interviewsIndustries Software development

Question

Review this Python helper that converts an uploaded video.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts
Talk through your review
Code to reviewpython
import subprocess def make_thumbnail(filename, timestamp):    out = filename + '.jpg'    cmd = f"ffmpeg -i {filename} -ss {timestamp} -vframes 1 {out}"    subprocess.run(cmd, shell=True, check=True)    return out
Run or narrate your approach, then ask the coach.