Code reviewMediumcr-g030

Subject Command injectionLevel Mid–Senior~20 minCommon in Security interviewsIndustries Software development

Question

Review this Node.js diagnostics endpoint on a network appliance.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjs

1const { exec } = require('child_process');2 3app.post('/api/ping', (req, res) => {4  const host = req.body.host;5  exec(`ping -c 3 ${host}`, (err, stdout) => {6    if (err) return res.status(500).json({ error: 'ping failed' });7    res.json({ output: stdout });8  });9});

Run or narrate your approach, then ask the coach.