Ping endpoint command injection

Code reviewSecurityMid–Senior~20 min

Review this Node.js diagnostics endpoint on a network appliance.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 20 min

Mark a line and say what kind of problem it is.0 findings

1const { exec } = require('child_process');

3app.post('/api/ping', (req, res) => {

4 const host = req.body.host;

5 exec(`ping -c 3 ${host}`, (err, stdout) => {

6 if (err) return res.status(500).json({ error: 'ping failed' });

7 res.json({ output: stdout });

8 });

9});

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.