Invoice endpoint missing ownership check
Review this Java Spring controller for downloading an invoice.
What a strong answer looks like
Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.
0:00 of about 25 min
Mark a line and say what kind of problem it is.0 findings
1@GetMapping("/api/invoices/{id}")
2public ResponseEntity<InvoiceDto> getInvoice(@PathVariable Long id,
3 @AuthenticationPrincipal User me) {
4 Invoice inv = invoiceRepo.findById(id)
5 .orElseThrow(() -> new NotFoundException());
6 return ResponseEntity.ok(InvoiceMapper.toDto(inv));
7}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.
Run or narrate your approach, then ask the coach.