Code reviewHardcr-g039

Subject Insecure deserializationLevel Senior–Staff~30 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Python caching layer that stores objects in Redis.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1import pickle, redis2r = redis.Redis()3 4def cache_set(key, obj):5    r.set(key, pickle.dumps(obj))6 7def cache_get(key):8    raw = r.get(key)9    if raw is None:10        return None11    return pickle.loads(raw)        # rehydrate

Run or narrate your approach, then ask the coach.