Code reviewHardcr-g142

Subject Missing validationLevel Senior–Staff~24 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Go file-download endpoint.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func Download(w http.ResponseWriter, r *http.Request) {2    name := r.URL.Query().Get("file")3    path := filepath.Join("/srv/uploads", name)4    data, err := os.ReadFile(path)5    if err != nil {6        http.Error(w, "not found", 404)7        return8    }9    w.Header().Set("Content-Type", "application/octet-stream")10    w.Write(data)11}

Run or narrate your approach, then ask the coach.