Code reviewMediumcr-g240

Subject Jwt misuseLevel Mid–Senior~25 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Go JWT validation helper.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func parseClaims(tokenStr string, secret []byte) (jwt.MapClaims, error) {2	token, err := jwt.Parse(tokenStr, func(t *jwt.Token) (interface{}, error) {3		return secret, nil4	})5	if err != nil {6		return nil, err7	}8	if claims, ok := token.Claims.(jwt.MapClaims); ok && token.Valid {9		return claims, nil10	}11	return nil, errors.New("invalid claims")12}

Run or narrate your approach, then ask the coach.