XML parser allows external entities

Code reviewCode quality & reviewSenior–Staff~30 min

Review this Java XML upload parser for SAML/SOAP payloads.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 30 min

Mark a line and say what kind of problem it is.0 findings

1public Document parse(InputStream xml) throws Exception {

2 DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();

3 dbf.setNamespaceAware(true);

4 DocumentBuilder db = dbf.newDocumentBuilder();

5 return db.parse(xml);

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.