Code reviewHardcr-g248

Subject XxeLevel Senior–Staff~30 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java XML upload parser for SAML/SOAP payloads.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1public Document parse(InputStream xml) throws Exception {2    DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();3    dbf.setNamespaceAware(true);4    DocumentBuilder db = dbf.newDocumentBuilder();5    return db.parse(xml);6}

Run or narrate your approach, then ask the coach.