Redirect bypasses host allowlist

Code reviewCode quality & reviewSenior–Staff~35 min

Review this Java internal-API proxy with a host allowlist.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 35 min

Mark a line and say what kind of problem it is.0 findings

1public String proxy(String rawUrl) throws Exception {

2 URL u = new URL(rawUrl);

3 if (!u.getHost().endsWith("trusted.internal.example.com")) {

4 throw new SecurityException("host not allowed");

5 }

6 HttpURLConnection c = (HttpURLConnection) u.openConnection();

7 c.setInstanceFollowRedirects(true);

8 return new String(c.getInputStream().readAllBytes());

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.