Full table scan instead of filter
Review this Python data-access function that returns recent active orders for one customer. The orders table has tens of millions of rows.
What a strong answer looks like
Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.
0:00 of about 18 min
Mark a line and say what kind of problem it is.0 findings
1def recent_active_orders(db, customer_id, since):
2 rows = db.execute("SELECT * FROM orders").fetchall()
3 result = []
4 for r in rows:
5 if r["customer_id"] == customer_id and r["status"] == "active" and r["created_at"] >= since:
6 result.append(r)
7 return result
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.
Run or narrate your approach, then ask the coach.