Code reviewHardcr-g335

Subject LocaleLevel Senior–Staff~20 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java filter that authorizes admin-only routes by normalizing the role claim before comparing.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1private static final String ADMIN = "ADMIN";2 3boolean isAdminRole(String role) {4    // role comes off the request token, e.g. "admin"5    if (role == null) {6        return false;7    }8    String normalized = role.trim().toUpperCase();9    return normalized.equals(ADMIN);10}11 12void handle(Request req) {13    if (!isAdminRole(req.role())) {14        throw new ForbiddenException();15    }16    // ... privileged work17}

Run or narrate your approach, then ask the coach.