Code reviewMediumcr-g366

Subject Input validationLevel Mid–Senior~20 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Python OAuth-callback handler that redirects back to a client-supplied URL.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1@app.get('/auth/callback')2def callback():3    code = request.args['code']4    next_url = request.args.get('next', '/dashboard')5    token = exchange_code(code)6    resp = redirect(next_url)7    resp.set_cookie('session', token, httponly=True)8    return resp

Run or narrate your approach, then ask the coach.