Code reviewHardcr-g441

Subject XxeLevel Senior–Staff~22 minCommon in Code quality & review interviewsIndustries Software development, Technology

Question

Review this Java method that parses an inbound SOAP body with a SAX reader.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1public void handleSoap(String soapBody, ContentHandler handler) throws Exception {2    SAXParserFactory spf = SAXParserFactory.newInstance();3    spf.setNamespaceAware(true);4    SAXParser parser = spf.newSAXParser();5    XMLReader reader = parser.getXMLReader();6    reader.setContentHandler(handler);7    reader.setErrorHandler(new DefaultHandler());8    InputSource src = new InputSource(new StringReader(soapBody));9    reader.parse(src);10    log.info("parsed soap body, {} bytes", soapBody.length());11}

Run or narrate your approach, then ask the coach.