Git clone from user URL
Review this Python CI service that clones a user-supplied repo URL, correctly avoiding the shell.
What a strong answer looks like
Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.
0:00 of about 24 min
Mark a line and say what kind of problem it is.0 findings
1import subprocess, os
2
3def clone(repo_url, build_id):
4 dest = os.path.join('/tmp/builds', build_id)
5 os.makedirs(dest, exist_ok=True)
6 subprocess.run(
7 ['git', 'clone', '--depth', '1', repo_url, dest],
8 check=True,
9 timeout=120,
10 capture_output=True,
11 )
12 return dest
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.
Run or narrate your approach, then ask the coach.