YAML deserialization executes code

Code reviewML systemsMid–Senior~18 min

Review this Python endpoint that loads a user-uploaded YAML pipeline definition.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1import yaml

3@app.route('/pipelines', methods=['POST'])

4@login_required

5def create_pipeline():

6 uploaded = request.files['spec'].read()

7 spec = yaml.load(uploaded, Loader=yaml.Loader)

8 steps = spec.get('steps', [])

9 commands = [s['run'] for s in steps]

10 pipeline_id = store.save(owner=current_user.id, steps=commands)

11 return {'id': pipeline_id, 'steps': len(commands)}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.