Code reviewMediumcr-g465

Subject CorrectnessLevel Entry–Mid~14 minCommon in Code quality & review · Algorithms & data structures interviewsIndustries Software development

Question

Review this Java code that authorizes a request by comparing the role parsed from the request body against a constant.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1String role = parseRoleFromBody(req); // e.g. "admin"2if (role == "admin") {3    grantAdmin();4}

Run or narrate your approach, then ask the coach.