MongoDB query accepts plaintext password

Code reviewSecurityDatabases & SQLMid–Senior~18 min

Review this Node.js MongoDB authentication query.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1app.post('/api/auth', async (req, res) => {

2 // body parsed as JSON

3 const user = await db.collection('users').findOne({

4 username: req.body.username,

5 password: req.body.password,

6 });

7 if (user) {

8 req.session.uid = user._id;

9 return res.json({ ok: true });

10 }

11 res.status(401).json({ ok: false });

12});

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.