Code reviewHardcr-g557

Subject Security missing authorization adminLevel Senior–Staff~18 minCommon in Security interviewsIndustries Software development, IT services

Question

Review this Spring MVC admin endpoint.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1@RestController2@RequestMapping("/admin")3public class AdminController {4 5    @PostMapping("/users/{id}/delete")6    public ResponseEntity<Void> deleteUser(@PathVariable Long id,7                                           @RequestHeader("Authorization") String auth) {8        if (auth == null || auth.isEmpty()) {9            return ResponseEntity.status(401).build();10        }11        userService.delete(id);12        return ResponseEntity.ok().build();13    }14}

Run or narrate your approach, then ask the coach.