Code reviewHardcr-g559

Subject Security input validation xxeLevel Senior–Staff~20 minCommon in ML systems · Security · Algorithms & data structures interviewsIndustries Software development, IT services

Question

Review this Java endpoint that parses an uploaded XML document.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1public Document parseUpload(InputStream xml) throws Exception {2    DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();3    DocumentBuilder builder = dbf.newDocumentBuilder();4    Document doc = builder.parse(xml);5    doc.getDocumentElement().normalize();6    return doc;7}

Run or narrate your approach, then ask the coach.