Overly permissive CORS with credentials

Code reviewSecurityMid–Senior~18 min

Review this Express CORS configuration for an authenticated API.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1app.use((req, res, next) => {

2 res.header('Access-Control-Allow-Origin', req.headers.origin || '*');

3 res.header('Access-Control-Allow-Credentials', 'true');

4 res.header('Access-Control-Allow-Headers', 'Content-Type, Authorization');

5 next();

6});

8app.get('/api/me', requireSession, (req, res) => {

9 res.json({ id: req.user.id, email: req.user.email });

10});

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.