Weak random token generation

Code reviewSecurityMid–Senior~20 min

Review this JavaScript password-reset token generator (Node.js).

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 20 min

Mark a line and say what kind of problem it is.0 findings

1function generateResetToken() {

2 let token = '';

3 const chars = 'abcdefghijklmnopqrstuvwxyz0123456789';

4 for (let i = 0; i < 24; i++) {

5 token += chars[Math.floor(Math.random() * chars.length)];

6 }

7 return token;

10async function requestReset(email) {

11 const token = generateResetToken();

12 await db.resets.insert({ email, token, expires: Date.now() + 3600_000 });

13 await sendResetEmail(email, token);

14}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.