Code reviewHardcr-g567

Subject Ssrf vulnerabilityLevel Senior–Staff~30 minCommon in Security · Networking & APIs interviewsIndustries Software development, Technology

Question

Review this Go webhook-delivery worker.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func deliverWebhook(endpoint string, payload []byte) error {2    parsed, err := url.Parse(endpoint)3    if err != nil {4        return err5    }6    if parsed.Hostname() == "localhost" || parsed.Hostname() == "127.0.0.1" {7        return errors.New("blocked")8    }9    resp, err := http.Post(endpoint, "application/json", bytes.NewReader(payload))10    if err != nil {11        return err12    }13    defer resp.Body.Close()14    return nil15}

Run or narrate your approach, then ask the coach.