Config file parsed with YAML.load

Code reviewSecurityMid–Senior~22 min

Review this Ruby config-import feature.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 22 min

Mark a line and say what kind of problem it is.0 findings

1require 'yaml'

3class ConfigController < ApplicationController

4 def import

5 uploaded = params[:config_file].read

6 config = YAML.load(uploaded) # parse user-uploaded settings file

7 current_tenant.apply_settings(config)

8 redirect_to settings_path, notice: 'Imported'

9 end

10end

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.