Code RoomEmail template renders user-supplied body
HardPrep Room Coding #2196

Email template renders user-supplied body

Code reviewSecuritySenior–Staff~28 min

Review this Python email-template renderer (Flask + Jinja2).

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 28 min
Mark a line and say what kind of problem it is.0 findings
1from jinja2 import Template
2 
3@app.route('/preview', methods=['POST'])
4def preview_email():
5 subject = request.form['subject']
6 body_template = request.form['body'] # user-authored marketing template
7 rendered = Template('<h1>' + subject + '</h1>' + body_template).render(
8 name=current_user.name
9 )
10 return rendered
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.