Code RoomPath traversal reads arbitrary files

MediumPrep Room Coding #2278

Path traversal reads arbitrary files

Code reviewSecurityMid–Senior~18 min

Review this 'download invoice' handler.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1@app.get('/invoices/<invoice_id>')

2def download(invoice_id):

3 inv = Invoice.get(invoice_id)

4 return send_file(inv.pdf_path)

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.