Code reviewMediumcr-p004

Subject SecurityLevel Mid–Senior~18 minCommon in Security interviewsIndustries Software development

Question

Review this 'download invoice' handler.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1@app.get('/invoices/<invoice_id>')2def download(invoice_id):3    inv = Invoice.get(invoice_id)4    return send_file(inv.pdf_path)

Run or narrate your approach, then ask the coach.