Code RoomTiming attack on signature

MediumPrep Room Coding #2388

Timing attack on signature

Code reviewSecuritySenior~18 min

Review this webhook signature verification.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1expected = hmac.new(secret, body, 'sha256').hexdigest()

2if signature == expected:

3 process(body)

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.